| 475 |
succeeds to invoke do_execve() with filename = "/bin/ls" and |
succeeds to invoke do_execve() with filename = "/bin/ls" and |
| 476 |
argv[0] = "/bin/cat". |
argv[0] = "/bin/cat". |
| 477 |
|
|
| 478 |
I introduced a keyword that permits the mismatch of |
I introduced a directive that permits the mismatch of |
| 479 |
basename of filename and argv[0]. |
basename of filename and argv[0]. |
| 480 |
|
|
| 481 |
Fix 2006/08/10 |
Fix 2006/08/10 |
| 1146 |
|
|
| 1147 |
Fix 2008/02/05 |
Fix 2008/02/05 |
| 1148 |
|
|
| 1149 |
@ Use find_task_by_vpid() instead of find_task_pid(). |
@ Use find_task_by_vpid() instead of find_task_by_pid(). |
| 1150 |
|
|
| 1151 |
Kernel 2.6.24 introduced PID namespace. |
Kernel 2.6.24 introduced PID namespace. |
| 1152 |
To search PID given from userland, the kernel needs to use |
To search PID given from userland, the kernel needs to use |
| 1153 |
find_task_by_vpid() instead of find_task_pid(). |
find_task_by_vpid() instead of find_task_by_pid(). |
| 1154 |
|
|
| 1155 |
Fix 2008/02/14 |
Fix 2008/02/14 |
| 1156 |
|
|
| 1259 |
|
|
| 1260 |
Fix 2008/03/03 |
Fix 2008/03/03 |
| 1261 |
|
|
| 1262 |
@ Add "force_alt_exec" keyword. |
@ Add "force_alt_exec" directive. |
| 1263 |
|
|
| 1264 |
To be able to fully utilize "alt_exec" feature, |
To be able to fully utilize "alt_exec" feature, |
| 1265 |
I added "force_alt_exec" keyword so that |
I added "force_alt_exec" directive so that |
| 1266 |
all execute requests are replaced by the execute request of a program |
all execute requests are replaced by the execute request of a program |
| 1267 |
specified by alt_exec feature. |
specified by alt_exec feature. |
| 1268 |
|
|
| 1269 |
If this keyword is specified for a domain, the domain no longer |
If this directive is specified for a domain, the domain no longer |
| 1270 |
executes any programs regardless of the mode of file access control |
executes any programs regardless of the mode of file access control |
| 1271 |
(i.e. the domain won't execute even if MAC_FOR_FILE=0 ). |
(i.e. the domain won't execute even if MAC_FOR_FILE=0 ). |
| 1272 |
Instead, the domain executes the program specified by alt_exec feature |
Instead, the domain executes the program specified by alt_exec feature |
| 1301 |
|
|
| 1302 |
Fix 2008/03/10 |
Fix 2008/03/10 |
| 1303 |
|
|
| 1304 |
@ Rename "force_alt_exec" keyword to "execute_handler". |
@ Rename "force_alt_exec" directive to "execute_handler". |
| 1305 |
|
|
| 1306 |
To be able to use different programs for validating execve() parameters, |
To be able to use different programs for validating execve() parameters, |
| 1307 |
I moved the location to specify the program's pathname from profile |
I moved the location to specify the program's pathname from profile |
| 1308 |
to domain policy. |
to domain policy. |
| 1309 |
|
|
| 1310 |
The "execute_handler" keyword takes one pathname which is |
The "execute_handler" directive takes one pathname which is |
| 1311 |
invoked whenever execve() request is issued. Thus, any "allow_execute" |
invoked whenever execve() request is issued. Thus, any "allow_execute" |
| 1312 |
keywords in a domain with "execute_handler" are ignored. |
directives in a domain with "execute_handler" are ignored. |
| 1313 |
This keyword is designed for validating expected/desirable execve() |
This directive is designed for validating expected/desirable execve() |
| 1314 |
requests in userspace, although there is no way to tell the caller |
requests in userspace, although there is no way to tell the caller |
| 1315 |
that the execve() request was rejected. |
that the execve() request was rejected. |
| 1316 |
|
|
| 1317 |
@ Rename "alt_exec" keyword to "denied_execute_handler". |
@ Rename "alt_exec" directive to "denied_execute_handler". |
| 1318 |
|
|
| 1319 |
The "denied_execute_handler" keyword takes one pathname which is |
The "denied_execute_handler" directive takes one pathname which is |
| 1320 |
invoked only when execve() request was rejected. In other words, |
invoked only when execve() request was rejected. In other words, |
| 1321 |
this program is invoked only when the following conditions are met. |
this program is invoked only when the following conditions are met. |
| 1322 |
|
|
| 1323 |
(1) None of "allow_execute" keywords in the domain matched. |
(1) None of "allow_execute" directives in the domain matched. |
| 1324 |
(2) The execve() request was rejected in enforcing mode. |
(2) The execve() request was rejected in enforcing mode. |
| 1325 |
(3) "execute_handler" keyword is not used by the domain. |
(3) "execute_handler" directive is not used by the domain. |
| 1326 |
|
|
| 1327 |
This keyword is designed for handling unexpected/undesirable execve() |
This directive is designed for handling unexpected/undesirable execve() |
| 1328 |
requests, to redirect the process issuing such requests to somewhere. |
requests, to redirect the process issuing such requests to somewhere. |
| 1329 |
|
|
| 1330 |
Fix 2008/03/18 |
Fix 2008/03/18 |
| 1342 |
@ Disable execute handler loop. |
@ Disable execute handler loop. |
| 1343 |
|
|
| 1344 |
To be able to use "execute_handler" in a "keep_domain" domain, |
To be able to use "execute_handler" in a "keep_domain" domain, |
| 1345 |
ignore "execute_handler" and "denied_execute_handler" keywords |
ignore "execute_handler" and "denied_execute_handler" directives |
| 1346 |
if the current process is executing programs specified by |
if the current process is executing programs specified by |
| 1347 |
"execute_handler" or "denied_execute_handler" keyword. |
"execute_handler" or "denied_execute_handler" directive. |
| 1348 |
|
|
| 1349 |
This exception is needed to avoid infinite execute handler loop. |
This exception is needed to avoid infinite execute handler loop. |
| 1350 |
If a domain has both "keep_domain" and "execute_handler", |
If a domain has both "keep_domain" and "execute_handler", |
| 1360 |
|
|
| 1361 |
Version 1.6.0 2008/04/01 Feature enhancement release. |
Version 1.6.0 2008/04/01 Feature enhancement release. |
| 1362 |
|
|
| 1363 |
Fix 2008/??/?? |
Fix 2008/04/14 |
| 1364 |
|
|
| 1365 |
@ Fix "Compilation failures" and "Initialization ordering bugs" |
@ Fix "Compilation failures" and "Initialization ordering bugs" |
| 1366 |
with kernels before 2.4.30/2.6.11 . |
with kernels before 2.4.30/2.6.11 . |
| 1369 |
resulting compilation error at #include <linux/hardirq.h> . |
resulting compilation error at #include <linux/hardirq.h> . |
| 1370 |
I added #elif condition. |
I added #elif condition. |
| 1371 |
|
|
| 1372 |
2.6 kernels before 2.6.11 calls do_execve() before initialization of |
CentOS 4.6's 2.6.9 kernel calls do_execve() before initialization of |
| 1373 |
ccs_alloc(), resulting NULL pointer dereference. |
ccs_alloc(), resulting NULL pointer dereference. |
| 1374 |
I changed __initcall to fs_initcall. |
I changed __initcall to core_initcall. |
| 1375 |
|
|
| 1376 |
Some distributions with 2.6.9 kernels backported kzalloc() from 2.6.14 , |
CentOS 4.6's 2.6.9 kernel backported kzalloc() from 2.6.14 , |
| 1377 |
resulting compilation error at kzalloc(). |
resulting compilation error at kzalloc(). |
| 1378 |
I modified prototype of kzalloc(). |
I modified prototype of kzalloc(). |
| 1379 |
|
|
| 1380 |
|
Fix 2008/04/20 |
| 1381 |
|
|
| 1382 |
|
@ Fix "Compilation failures" with kernels before 2.4.30/2.6.11 . |
| 1383 |
|
|
| 1384 |
|
Turbolinux 10 Server's 2.6.8 kernel backported kzalloc() as an inlined |
| 1385 |
|
function, resulting compilation error at kzalloc(). |
| 1386 |
|
I converted kzalloc() from an inlined function into a macro. |
| 1387 |
|
|
| 1388 |
|
Fix 2008/04/21 |
| 1389 |
|
|
| 1390 |
|
@ Add workaround for gcc 3.2.2's inline bug. |
| 1391 |
|
|
| 1392 |
|
RedHat Linux 9's gcc 3.2.2 generated a bad code |
| 1393 |
|
if ((var_of_u8 & 0x000000BF) & 0x80000000) { } |
| 1394 |
|
where the expected code is |
| 1395 |
|
if ((var_of_u8 & 0xBF) & 0x80) { } |
| 1396 |
|
when embedding ccs_acl_type2() into print_entry(), |
| 1397 |
|
resulting runtime BUG(). |
| 1398 |
|
I added the expected code explicitly as a workaround. |
| 1399 |
|
|
| 1400 |
|
Fix 2008/05/06 |
| 1401 |
|
|
| 1402 |
|
@ Add memory quota. |
| 1403 |
|
|
| 1404 |
|
1.5.x returns -ENOMEM when FindNextDomain() failed to create a new |
| 1405 |
|
domain, but I forgot to return -ENOMEM when find_next_domain() failed to |
| 1406 |
|
create a new domain. |
| 1407 |
|
|
| 1408 |
|
A domain is automatically created by find_next_domain() only if |
| 1409 |
|
the domain for the requested program doesn't exist. |
| 1410 |
|
This behavior is for the administrator's convenience. |
| 1411 |
|
The administrator needn't to know how many domains are needed for running |
| 1412 |
|
the whole programs in the system beforehand when developing the policy. |
| 1413 |
|
But the administrator does not want the kernel to reject execution of the |
| 1414 |
|
requested program when developing the policy. |
| 1415 |
|
|
| 1416 |
|
So, I think it is better to grant execution of programs even if |
| 1417 |
|
find_next_domain() failed to create a new domain than reject execution. |
| 1418 |
|
Thus, I decided not to return -ENOMEM when find_next_domain() failed to |
| 1419 |
|
create a new domain. This exception breaks the domain transition rules, |
| 1420 |
|
so I print "transition_failed" warning in /proc/ccs/domain_policy |
| 1421 |
|
when this exception happened. |
| 1422 |
|
|
| 1423 |
|
Also, to prevent the system from being halted by unexpectedly allocating |
| 1424 |
|
all kernel memory for the policy, I added memory quota. |
| 1425 |
|
This quota is configurable via /proc/ccs/meminfo like |
| 1426 |
|
|
| 1427 |
|
echo Shared: 1048576 > /proc/ccs/meminfo |
| 1428 |
|
echo Private: 1048576 > /proc/ccs/meminfo |
| 1429 |
|
|
| 1430 |
|
Version 1.6.1 2008/05/10 Bug fix release. |
| 1431 |
|
|
| 1432 |
|
Fix 2008/06/04 |
| 1433 |
|
|
| 1434 |
|
@ Check open mode of /proc/ccs/ interface. |
| 1435 |
|
|
| 1436 |
|
It turned out that I can avoid allocating memory for reading if |
| 1437 |
|
FMODE_READ is not set and memory for writing if FMODE_WRITE is not set. |
| 1438 |
|
|
| 1439 |
|
@ Wait for completion of /sbin/ccs-init . |
| 1440 |
|
|
| 1441 |
|
Since 2.4 kernel's call_usermodehelper() can't wait for termination of |
| 1442 |
|
the executed program, I was using the close() request of |
| 1443 |
|
/proc/ccs/meminfo to indicate that loading policy has finished. |
| 1444 |
|
But since /proc/ccs/meminfo could be accessed for setting memory quota |
| 1445 |
|
by /etc/ccs/ccs-post-init , I stopped using the close() request. |
| 1446 |
|
The policy loader no longer need to access /proc/ccs/meminfo to notify |
| 1447 |
|
the kernel that loading policy has finished. |
| 1448 |
|
|
| 1449 |
|
Fix 2008/06/05 |
| 1450 |
|
|
| 1451 |
|
@ Fix realpath for pipes and sockets. |
| 1452 |
|
|
| 1453 |
|
Kernel 2.6.22 and later use different method for calculating d_path(). |
| 1454 |
|
Since fs/realpath.c didn't notice the change, the realpath of pipes |
| 1455 |
|
appeared as "pipe:" rather than "pipe:[\$]" when they are opened via |
| 1456 |
|
/proc/PID/fd/ directory. |
| 1457 |
|
|
| 1458 |
|
@ Add process's information into /proc/ccs/query . |
| 1459 |
|
|
| 1460 |
|
While /proc/ccs/grant_log and /proc/ccs/reject_log contain process's |
| 1461 |
|
information, /proc/ccs/query doesn't contain it. |
| 1462 |
|
To be able to utilize ccs-queryd and ccs-notifyd more, I added it into |
| 1463 |
|
/proc/ccs/query . |
| 1464 |
|
|
| 1465 |
|
Fix 2008/06/10 |
| 1466 |
|
|
| 1467 |
|
@ Allow using patterns for globally readable files. |
| 1468 |
|
|
| 1469 |
|
To allow users specify locale specific files to globally readable files, |
| 1470 |
|
I relaxed checking in update_globally_readable_entry(). |
| 1471 |
|
|
| 1472 |
|
Fix 2008/06/11 |
| 1473 |
|
|
| 1474 |
|
@ Remove ALLOW_ENFORCE_GRACE parameter. |
| 1475 |
|
|
| 1476 |
|
Since unexpected requests caused by doing software updates can happen |
| 1477 |
|
in all profiles, users likely have to write ALLOW_ENFORCE_GRACE=enabled |
| 1478 |
|
to all profiles. And it makes meaningless to allow users to selectively |
| 1479 |
|
enable specific profile's ALLOW_ENFORCE_GRACE parameter. |
| 1480 |
|
So, I removed ALLOW_ENFORCE_GRACE parameter. |
| 1481 |
|
Now, the system behaves as if ALLOW_ENFORCE_GRACE=enabled is specified. |
| 1482 |
|
The behavior of "delayed enforcing" mode is defined in the following |
| 1483 |
|
order. |
| 1484 |
|
|
| 1485 |
|
(1) The requests are rejected immediately if nobody is opening |
| 1486 |
|
/proc/ccs/query interface. |
| 1487 |
|
(2) The requests will be rejected in 10 seconds if somebody other than |
| 1488 |
|
ccs-queryd (such as less(1)) is opening /proc/ccs/query interface, |
| 1489 |
|
for such process doesn't write dummy decisions. |
| 1490 |
|
|
| 1491 |
|
Fix 2008/06/22 |
| 1492 |
|
|
| 1493 |
|
@ Pass escaped pathname to audit_execute_handler_log(). |
| 1494 |
|
|
| 1495 |
|
I was passing unescaped pathname to audit_execute_handler_log() |
| 1496 |
|
which causes /proc/ccs/grant_log contain whitespace characters |
| 1497 |
|
if execute handler's pathname contains whitespace characters. |
| 1498 |
|
|
| 1499 |
|
Fix 2008/06/25 |
| 1500 |
|
|
| 1501 |
|
@ Return 0 when ccs_may_umount() succeeds. |
| 1502 |
|
|
| 1503 |
|
I forgot to clear error value in ccs_may_umount() when the requested |
| 1504 |
|
directory didn't match "deny_unmount" directive. As a result, any umount() |
| 1505 |
|
request with RESTRICT_UNMOUNT=enforcing returned -EPERM error. |
| 1506 |
|
|
| 1507 |
|
Version 1.6.2 2008/06/25 Usability enhancement release. |
| 1508 |
|
|
| 1509 |
|
Fix 2008/07/01 |
| 1510 |
|
|
| 1511 |
|
@ Fix "Compilation failure" with 2.4.20 kernel. |
| 1512 |
|
|
| 1513 |
|
RedHat Linux 9's 2.4.20 kernel backported O(1) scheduler patch, |
| 1514 |
|
resulting compilation error at ccs_load_policy(). |
| 1515 |
|
I added defined(TASK_DEAD) check. |
| 1516 |
|
|
| 1517 |
|
Fix 2008/07/08 |
| 1518 |
|
|
| 1519 |
|
@ Don't check permissions if vfsmount is NULL. |
| 1520 |
|
|
| 1521 |
|
Some filesystems (e.g. unionfs) pass NULL vfsmount. |
| 1522 |
|
I changed fs/tomoyo_file.c not to try to calculate pathnames |
| 1523 |
|
if vfsmount is NULL. |
| 1524 |
|
|
| 1525 |
|
Version 1.6.3 2008/07/15 Bug fix release. |
| 1526 |
|
|
| 1527 |
|
Fix 2008/08/21 |
| 1528 |
|
|
| 1529 |
|
@ Add workaround for gcc 4.3's bug. |
| 1530 |
|
|
| 1531 |
|
In some environments, fs/tomoyo_network.c could not be compiled |
| 1532 |
|
because of gcc 4.3's bug. |
| 1533 |
|
I modified save_ipv6_address() to use "integer literal" value |
| 1534 |
|
instead for "static const u8" variable. |
| 1535 |
|
|
| 1536 |
|
@ Change prototypes of some functions. |
| 1537 |
|
|
| 1538 |
|
To support 2.6.27 kernels, I replaced "struct nameidata" with |
| 1539 |
|
"struct path" for some functions. |
| 1540 |
|
|
| 1541 |
|
@ Detect distributor specific patches automatically. |
| 1542 |
|
|
| 1543 |
|
Since kernels with AppArmor patch applied is increasing, |
| 1544 |
|
I introduced a mechanism which determines whether specific patches |
| 1545 |
|
are applied or not, based on "#define" directives in the patches. |
| 1546 |
|
|
| 1547 |
|
Fix 2008/08/29 |
| 1548 |
|
|
| 1549 |
|
@ Remove "-ccs" suffix from Makefile's EXTRAVERSION. |
| 1550 |
|
|
| 1551 |
|
To reduce conflicts on Makefile's EXTRAVERSION, |
| 1552 |
|
I removed "-ccs" suffix from ccs-patch-2.\*.diff . |
| 1553 |
|
Those who build kernels without using specs/build-\*.sh , |
| 1554 |
|
please edit EXTRAVERSION tag manually so that original kernels |
| 1555 |
|
will not be overwritten by TOMOYO Linux kernels. |
| 1556 |
|
|
| 1557 |
|
Version 1.6.4 2008/09/03 Minor update release. |
| 1558 |
|
|
| 1559 |
|
Fix 2008/09/09 |
| 1560 |
|
|
| 1561 |
|
@ Add "try again" response to "delayed enforcing" mode. |
| 1562 |
|
|
| 1563 |
|
To be able to handle pathname changes caused by software updates, |
| 1564 |
|
"delayed enforcing" mode was introduced. It allows administrator to |
| 1565 |
|
grant access requests which are about to be rejected by the kernel. |
| 1566 |
|
|
| 1567 |
|
To be able to handle pathname changes caused by software updates better, |
| 1568 |
|
I introduced "try again" response. As "delayed enforcing" mode sleeps |
| 1569 |
|
a process which violated policy, administrator can update policy while |
| 1570 |
|
the process is sleeping. This "try again" response allows administrator |
| 1571 |
|
to restart policy checks from the beginning after updating policy. |
| 1572 |
|
|
| 1573 |
|
Fix 2008/09/11 |
| 1574 |
|
|
| 1575 |
|
@ Remember whether the process is allowed to write to /proc/ccs/ interface. |
| 1576 |
|
|
| 1577 |
|
Since programs for manipulating policy (e.g. ccs-queryd ) are installed |
| 1578 |
|
in the form of RPM/DEB packages, these programs lose the original |
| 1579 |
|
pathnames when they are updated by the package manager. The package |
| 1580 |
|
manager renames these programs before deleting these programs so that |
| 1581 |
|
the package manager can rollback the operation. |
| 1582 |
|
This causes a problem when the programs are listed into /proc/ccs/manager |
| 1583 |
|
using pathnames, as the programs will no longer be allowed to write to |
| 1584 |
|
/proc/ccs/ interface while the process of old version of the program is |
| 1585 |
|
alive. |
| 1586 |
|
|
| 1587 |
|
To solve this problem, I modified to remember the fact that the process |
| 1588 |
|
is once allowed to write to /proc/ccs/ interface until the process |
| 1589 |
|
attempts to execute a different program. |
| 1590 |
|
This change makes it impossible to revoke permission to write to |
| 1591 |
|
/proc/ccs/ interface without killing the process, but it will be better |
| 1592 |
|
than nonfunctioning ccs-queryd program. |
| 1593 |
|
|
| 1594 |
|
Fix 2008/09/19 |
| 1595 |
|
|
| 1596 |
|
@ Allow selecting a domain by PID. |
| 1597 |
|
|
| 1598 |
|
Sometimes we want to know what ACLs are given to specific PID, but |
| 1599 |
|
finding a domainname for that PID from /proc/ccs/.process_status and |
| 1600 |
|
reading ACLs from /proc/ccs/domain_policy by the domainname is very slow. |
| 1601 |
|
Thus, I modified /proc/ccs/domain_policy to allow selecting a domain by |
| 1602 |
|
PID. For example, to read domain ACL of current process from bash, |
| 1603 |
|
run as follows. |
| 1604 |
|
|
| 1605 |
|
# exec 100<>/proc/ccs/domain_policy |
| 1606 |
|
# echo select pid=$$ >&100 |
| 1607 |
|
# while read -u 100; do echo $REPLY; done |
| 1608 |
|
|
| 1609 |
|
If a domain is once selected by PID, reading /proc/ccs/domain_policy will |
| 1610 |
|
print only that domain if that PID exists or print nothing otherwise. |
| 1611 |
|
|
| 1612 |
|
@ Disallow concurrent /proc/ccs/ access using the same file descriptor. |
| 1613 |
|
|
| 1614 |
|
Until now, one process can read() from /proc/ccs/ while other process |
| 1615 |
|
that shares the file descriptor can write() to /proc/ccs/ . |
| 1616 |
|
But to implement "Allow selecting a domain by PID" feature, I disabled |
| 1617 |
|
concurrent read()/write() because the feature need to modify read buffer |
| 1618 |
|
while writing. |
| 1619 |
|
|
| 1620 |
|
Fix 2008/10/01 |
| 1621 |
|
|
| 1622 |
|
@ Add retry counter into /proc/ccs/query . |
| 1623 |
|
|
| 1624 |
|
To be able to handle some of queries from /proc/ccs/query without user's |
| 1625 |
|
interaction, I added retry counter for avoiding infinite loop caused by |
| 1626 |
|
"try again" response. |
| 1627 |
|
|
| 1628 |
|
Fix 2008/10/07 |
| 1629 |
|
|
| 1630 |
|
@ Don't transit to new domain until do_execve() succeeds. |
| 1631 |
|
|
| 1632 |
|
Until now, a process's domain was updated to new domain which the process |
| 1633 |
|
will belong to before do_execve() succeeds so that the kernel can do |
| 1634 |
|
permission checks for interpreters and environment variables based on |
| 1635 |
|
new domain. But this caused a subtle problem when other process sends |
| 1636 |
|
signals to the process, for the process returns to old domain if |
| 1637 |
|
do_execve() failed. |
| 1638 |
|
|
| 1639 |
|
So, I modified to pass new domain to functions so that I can avoid |
| 1640 |
|
modifying a process's domain before do_execve() succeeds. |
| 1641 |
|
|
| 1642 |
|
@ Use old task state for audit logs. |
| 1643 |
|
|
| 1644 |
|
Until now, audit logs were generated using the task state after |
| 1645 |
|
processing "; set task.state" part. But to generate accurate logs, |
| 1646 |
|
I modified to save the task state before processing "; set task.state" |
| 1647 |
|
part and use the saved state for audit logs. |
| 1648 |
|
|
| 1649 |
|
@ Use a structure for passing parameters. |
| 1650 |
|
|
| 1651 |
|
As the number of parameters is increasing, I modified to use a structure |
| 1652 |
|
for passing parameters. |
| 1653 |
|
|
| 1654 |
|
Fix 2008/10/11 |
| 1655 |
|
|
| 1656 |
|
@ Remove domain_acl_lock mutex. |
| 1657 |
|
|
| 1658 |
|
I noticed that I don't need to keep all functions that modify an ACL of |
| 1659 |
|
a domain mutually exclusive. Since each functions handles different type |
| 1660 |
|
of ACL, locking is needed only when they append an ACL to a domain. |
| 1661 |
|
So, I modified to use local locks. |
| 1662 |
|
|
| 1663 |
|
Fix 2008/10/14 |
| 1664 |
|
|
| 1665 |
|
@ Fix ccs_check_condition() bug. |
| 1666 |
|
|
| 1667 |
|
Due to a bug in ccs_check_condition(), it was impossible to use |
| 1668 |
|
task.state[0] task.state[1] task.state[2] inside condition part |
| 1669 |
|
if the ACL does not treat a pathname. For example, an ACL like |
| 1670 |
|
|
| 1671 |
|
allow_network TCP connect @HTTP_SERVERS 80 if task.state[0]=100 |
| 1672 |
|
|
| 1673 |
|
didn't work. |
| 1674 |
|
|
| 1675 |
|
Fix 2008/10/15 |
| 1676 |
|
|
| 1677 |
|
@ Show process information in /proc/ccs/.process_status . |
| 1678 |
|
|
| 1679 |
|
To be able to determine a process's type, I added a command "info PID" |
| 1680 |
|
which returns process information of the specified PID in |
| 1681 |
|
"PID manager=\* execute_handler=\* state[0]=\$ state[1]=\$ state[2]=\$" |
| 1682 |
|
format. |
| 1683 |
|
|
| 1684 |
|
Fix 2008/10/20 |
| 1685 |
|
|
| 1686 |
|
@ Use rcu_dereference() when walking the list. |
| 1687 |
|
|
| 1688 |
|
I was using "dependency ordering" for appending an element to a list |
| 1689 |
|
without asking the reader to take a lock. But "dependency ordering" |
| 1690 |
|
is not respected by DEC Alpha or by some aggressive value-speculation |
| 1691 |
|
compiler optimizations. |
| 1692 |
|
|
| 1693 |
|
On such environment, use of "dependency ordering" can lead to system |
| 1694 |
|
crash because the reader might read uninitialized value of newly |
| 1695 |
|
appended element. |
| 1696 |
|
|
| 1697 |
|
To prevent the reader from reading uninitialized value of newly appended |
| 1698 |
|
element, I inserted rcu_dereference() when walking the list. |
| 1699 |
|
|
| 1700 |
|
Fix 2008/11/04 |
| 1701 |
|
|
| 1702 |
|
@ Use sys_getpid() instead for current->pid. |
| 1703 |
|
|
| 1704 |
|
Kernel 2.6.24 introduced PID namespace. |
| 1705 |
|
|
| 1706 |
|
To compare PID given from userland, I can't use current->pid. |
| 1707 |
|
So, I modified to use sys_getpid() instead for current->pid. |
| 1708 |
|
|
| 1709 |
|
I modified to use task_tgid_nr_ns() for 2.6.25 and later instead for |
| 1710 |
|
current->tgid when checking /proc/self/ in get_absolute_path(). |
| 1711 |
|
|
| 1712 |
|
Fix 2008/11/07 |
| 1713 |
|
|
| 1714 |
|
@ Fix is_alphabet_char(). |
| 1715 |
|
|
| 1716 |
|
is_alphabet_char() should match 'A' - 'Z' and 'a' - 'z', |
| 1717 |
|
but was matching from 'A' - 'F' and 'a' - 'f'. |
| 1718 |
|
|
| 1719 |
|
@ Add /proc/ccs/.execute_handler . |
| 1720 |
|
|
| 1721 |
|
Process information became visible to userspace by |
| 1722 |
|
"Show process information in /proc/ccs/.process_status" feature. |
| 1723 |
|
However, programs specified by execute_handler directive may run as |
| 1724 |
|
non root user, making it impossible to see process information. |
| 1725 |
|
|
| 1726 |
|
So, I added a new interface that allows execute handler processes |
| 1727 |
|
to see process information. The content of /proc/ccs/.execute_handler is |
| 1728 |
|
identical to /proc/ccs/.process_status . |
| 1729 |
|
|
| 1730 |
|
Version 1.6.5 2008/11/11 Third anniversary release. |
| 1731 |
|
|
| 1732 |
|
Fix 2008/12/01 |
| 1733 |
|
|
| 1734 |
|
@ Introduce "task.type=execute_handler" condition. |
| 1735 |
|
|
| 1736 |
|
The execute_handler directive is very very powerful. You can use this |
| 1737 |
|
directive to do anything you want to do (e.g. logging and validating and |
| 1738 |
|
modifying command line parameters and environment variables, opening and |
| 1739 |
|
closing and redirecting files, creating pipes to implement antivirus and |
| 1740 |
|
spam filtering, deploying a DMZ between the ssh daemon and the login |
| 1741 |
|
shells). |
| 1742 |
|
|
| 1743 |
|
To be able to use this directive in a domain with keep_domain directive |
| 1744 |
|
while limiting access to resources needed for such purposes to only |
| 1745 |
|
programs invoked as an execute handler process, I added a new condition. |
| 1746 |
|
|
| 1747 |
|
In learning mode, "if task.type=execute_handler" condition part will be |
| 1748 |
|
automatically added for requests issued by an execute_handler process. |
| 1749 |
|
|
| 1750 |
|
@ Introduce file's type and permissions as conditions. |
| 1751 |
|
|
| 1752 |
|
To be able to limit file types a process can access, I added |
| 1753 |
|
new conditions for checking file's type and permissions. |
| 1754 |
|
For example, |
| 1755 |
|
|
| 1756 |
|
allow_read /etc/fstab if path1.type=file path1.perm=0644 |
| 1757 |
|
|
| 1758 |
|
will allow opening /etc/fstab for reading only if /etc/fstab is a regular |
| 1759 |
|
file and it's permission is 0644, and |
| 1760 |
|
|
| 1761 |
|
allow_write /dev/null if path1.type=char path1.dev_major=1 path1.dev_minor=3 |
| 1762 |
|
|
| 1763 |
|
will allow opening /dev/null for writing only if /dev/null is a character |
| 1764 |
|
device file with major=1 and minor=3 attributes. |
| 1765 |
|
|
| 1766 |
|
@ Add memory quota for temporary memory used for auditing. |
| 1767 |
|
|
| 1768 |
|
Although there are MAX_GRANT_LOG and MAX_REJECT_LOG parameters |
| 1769 |
|
which limit the number of entries for audit logs so that we can avoid |
| 1770 |
|
memory consumption by audit logs, it would be more convenient if we can |
| 1771 |
|
also limit the size in bytes. |
| 1772 |
|
Thus, I added a new quota line. |
| 1773 |
|
|
| 1774 |
|
echo Dynamic: 1048576 > /proc/ccs/meminfo |
| 1775 |
|
|
| 1776 |
|
This quota is not applied to temporary memory used for permission checks. |
| 1777 |
|
|
| 1778 |
|
Fix 2008/12/09 |
| 1779 |
|
|
| 1780 |
|
@ Fix ccs_can_save_audit_log() checks. |
| 1781 |
|
|
| 1782 |
|
Due to incorrect statement "if (ccs_can_save_audit_log() < 0)" |
| 1783 |
|
while ccs_can_save_audit_log() is boolean, MAX_GRANT_LOG and |
| 1784 |
|
MAX_REJECT_LOG were not working. |
| 1785 |
|
|
| 1786 |
|
This bug will trigger OOM killer if /usr/sbin/ccs-auditd is not working. |
| 1787 |
|
|
| 1788 |
|
Fix 2008/12/24 |
| 1789 |
|
|
| 1790 |
|
@ Add "ccs_" prefix. |
| 1791 |
|
|
| 1792 |
|
To be able to tell whether a symbol is TOMOYO Linux related or not, |
| 1793 |
|
I added "ccs_" prefix as much as possible. |
| 1794 |
|
|
| 1795 |
|
@ Fix ccs_check_flags() error message. |
| 1796 |
|
|
| 1797 |
|
I meant to print SYAORAN-ERROR: message when error == -EPERM, |
| 1798 |
|
but I was printing it when error == 0 since 1.6.0 . |
| 1799 |
|
|
| 1800 |
|
Fix 2009/01/05 |
| 1801 |
|
|
| 1802 |
|
@ Use kmap_atomic()/kunmap_atomic() for reading "struct linux_binprm". |
| 1803 |
|
|
| 1804 |
|
As remove_arg_zero() uses kmap_atomic(KM_USER0), I modified to use |
| 1805 |
|
kmap_atomic(KM_USER0) rather than kmap(). |
| 1806 |
|
|
| 1807 |
|
Fix 2009/01/28 |
| 1808 |
|
|
| 1809 |
|
@ Fix "allow_read" + "allow_write" != "allow_read/write" problem. |
| 1810 |
|
|
| 1811 |
|
Since 1.6.0 , due to a bug in ccs_update_single_path_acl(), |
| 1812 |
|
appending "allow_read/write" entry didn't update internal "allow_read" |
| 1813 |
|
and "allow_write" entries. As a result, attempt to open(O_RDWR) succeeds |
| 1814 |
|
but open(O_RDONLY) and open(O_WRONLY) fail. |
| 1815 |
|
|
| 1816 |
|
Workaround is to write an entry twice when newly appending that entry. |
| 1817 |
|
If written twice, internal "allow_read" and "allow_write" entries |
| 1818 |
|
are updated. |
| 1819 |
|
|
| 1820 |
|
Fix 2009/02/26 |
| 1821 |
|
|
| 1822 |
|
@ Fix profile read error. |
| 1823 |
|
|
| 1824 |
|
Incorrect profiles were shown in /proc/ccs/profile |
| 1825 |
|
if either CONFIG_SAKURA or CONFIG_TOMOYO is disabled. |
| 1826 |
|
|
| 1827 |
|
Fix 2009/03/02 |
| 1828 |
|
|
| 1829 |
|
@ Undelete CONFIG_TOMOYO_AUDIT option. |
| 1830 |
|
|
| 1831 |
|
While HDD-less systems can use profiles with MAX_GRANT_LOG=0 and |
| 1832 |
|
MAX_REJECT_LOG=0 , I undeleted CONFIG_TOMOYO_AUDIT option for saving |
| 1833 |
|
memory used for /proc/ccs/grant_log and /proc/ccs/reject_log interfaces. |
| 1834 |
|
|
| 1835 |
|
Fix 2009/03/13 |
| 1836 |
|
|
| 1837 |
|
@ Show only profile entry names ever specified. |
| 1838 |
|
|
| 1839 |
|
Even if an administrator specifies only COMMENT= and MAC_FOR_FILE= |
| 1840 |
|
entries for /proc/ccs/profile , all available profile entries are shown. |
| 1841 |
|
This was designed to help administrators to know what entries are |
| 1842 |
|
available, but sometimes makes administrators feel noisy because of |
| 1843 |
|
entries showing default values. |
| 1844 |
|
|
| 1845 |
|
Thus, I modified to show only profile entry names ever specified. |
| 1846 |
|
|
| 1847 |
|
Fix 2009/03/18 |
| 1848 |
|
|
| 1849 |
|
@ Add MAC_FOR_IOCTL functionality. |
| 1850 |
|
|
| 1851 |
|
To be able to restrict ioctl() requests, I added MAC_FOR_IOCTL |
| 1852 |
|
functionality. |
| 1853 |
|
|
| 1854 |
|
This functionality requires modification of ccs-patch-\*.diff . |
| 1855 |
|
|
| 1856 |
|
@ Use better name for socket's pathname. |
| 1857 |
|
|
| 1858 |
|
Until now, socket's pathname was represented as "socket:[\$]" format |
| 1859 |
|
where \$ is inode's number. But inode's number is useless for name based |
| 1860 |
|
access control. Therefore, I modified to represent socket's pathname as |
| 1861 |
|
"socket:[family=\$:type=\$:protocol=\$]" format. |
| 1862 |
|
|
| 1863 |
|
This will help administrator to control ioctl() against sockets more |
| 1864 |
|
precisely. |
| 1865 |
|
|
| 1866 |
|
@ Fix misplaced ccs_capable() call. (only 2.6.8-\* and 2.6.9-\*) |
| 1867 |
|
|
| 1868 |
|
Location to insert ccs_capable(TOMOYO_SYS_IOCTL) in sys_ioctl() was |
| 1869 |
|
wrong since version 1.1 . |
| 1870 |
|
|
| 1871 |
|
@ Insert ccs_check_ioctl_permission() call. |
| 1872 |
|
|
| 1873 |
|
To make MAC_FOR_IOCTL functionality working, I inserted |
| 1874 |
|
ccs_check_ioctl_permission() call into ccs-patch-\*.diff . |
| 1875 |
|
|
| 1876 |
|
Fix 2009/03/23 |
| 1877 |
|
|
| 1878 |
|
@ Move sysctl()'s check from ccs-patch-\*.diff to fs/tomoyo_file.c . |
| 1879 |
|
|
| 1880 |
|
Since try_parse_table() in kernel/sysctl.c is almost identical between |
| 1881 |
|
all versions, I moved that function to fs/tomoyo_file.c . |
| 1882 |
|
|
| 1883 |
|
@ Relocate definitions and functions. |
| 1884 |
|
|
| 1885 |
|
To reduce exposed symbols, I relocated some definitions and functions. |
| 1886 |
|
|
| 1887 |
|
Fix 2009/03/24 |
| 1888 |
|
|
| 1889 |
|
@ Add CONFIG_TOMOYO_BUILTIN_INITIALIZERS option. |
| 1890 |
|
|
| 1891 |
|
Some systems don't have /sbin/modprobe and /sbin/hotplug . |
| 1892 |
|
Thus, I made these pathnames configurable. |
| 1893 |
|
|
| 1894 |
|
Version 1.6.7 2009/04/01 Feature enhancement release. |
| 1895 |
|
|
| 1896 |
|
Fix 2009/04/06 |
| 1897 |
|
|
| 1898 |
|
@ Drop "undelete domain" command. |
| 1899 |
|
|
| 1900 |
|
I added "undelete domain" command on 2007/01/19, but never used by policy |
| 1901 |
|
management tools. The garbage collector I added on 2007/01/29 will |
| 1902 |
|
automatically reuse memory and allow administrators switch domain policy |
| 1903 |
|
periodically, provided that the administrator kills processes in old |
| 1904 |
|
domains before recreating new domains with the same domainnames. |
| 1905 |
|
|
| 1906 |
|
Thus, I dropped "undelete domain" command. |
| 1907 |
|
|
| 1908 |
|
@ Escape invalid characters in ccs_check_mount_permission2(). |
| 1909 |
|
|
| 1910 |
|
ccs_check_mount_permission2() was passing unencoded strings to printk() |
| 1911 |
|
and ccs_update_mount_acl() and ccs_check_supervisor(). This may cause |
| 1912 |
|
/proc/ccs/system_policy and /proc/ccs/query to contain invalid |
| 1913 |
|
characters within a string. |
| 1914 |
|
|
| 1915 |
|
Fix 2009/04/07 |
| 1916 |
|
|
| 1917 |
|
@ Fix IPv4's "address_group" handling error. |
| 1918 |
|
|
| 1919 |
|
Since 1.6.5 , due to lack of ntohl() (byte order conversion) in |
| 1920 |
|
ccs_update_address_group_entry(), "address_group" with IPv4 address was |
| 1921 |
|
not working. |
| 1922 |
|
|
| 1923 |
|
This problem happens on little endian platforms (e.g. x86). |
| 1924 |
|
|
| 1925 |
|
Fix 2009/04/20 |
| 1926 |
|
|
| 1927 |
|
@ Update recvmsg() hooks. |
| 1928 |
|
|
| 1929 |
|
Since 1.5.0, I was doing network access control for incoming UDP and RAW |
| 1930 |
|
packets inside skb_recv_datagram(). But to synchronize with LSM version, |
| 1931 |
|
I moved ccs_recv_datagram_permission() hook from skb_recv_datagram() to |
| 1932 |
|
udp_recvmsg()/udpv6_recvmsg()/raw_recvmsg()/rawv6_recvmsg() with name |
| 1933 |
|
change to ccs_recvmsg_permission(). |
| 1934 |
|
|
| 1935 |
|
Fix 2009/05/08 |
| 1936 |
|
|
| 1937 |
|
@ Add condition for symlink's target pathname. |
| 1938 |
|
|
| 1939 |
|
Until now, "allow_symlink" keyword allows creation of a symlink but does |
| 1940 |
|
not check the symlink's target. Usually it is no problem because |
| 1941 |
|
permission checks are done using dereferenced pathname. But in some |
| 1942 |
|
cases, we should restrict the symlink's target. For example, |
| 1943 |
|
"ln -s .htpasswd /var/www/html/readme.html" by CGI program should be |
| 1944 |
|
blocked because we will allow Apache to read both |
| 1945 |
|
/var/www/html/readme.html and /var/www/html/.htpasswd . |
| 1946 |
|
|
| 1947 |
|
Thus, I added new condition, "symlink.target". |
| 1948 |
|
|
| 1949 |
|
allow_symlink /var/www/html/\*.html if symlink.target="\*.html" |
| 1950 |
|
|
| 1951 |
|
allow_symlink /var/www/html/\*\-.\* if symlink.target="\*\-.\*" |
| 1952 |
|
|
| 1953 |
|
@ Don't return -EAGAIN at ccs_socket_recvmsg_permission(). |
| 1954 |
|
|
| 1955 |
|
It turned out that it is not permitted for accept() and recvmsg() to |
| 1956 |
|
return -EAGAIN if poll() said connections/datagrams are ready. However, |
| 1957 |
|
recvmsg() may return -EAGAIN and potentially confuse some applications |
| 1958 |
|
because ccs_socket_recvmsg_permission() is returning -EAGAIN. |
| 1959 |
|
|
| 1960 |
|
Thus, I modified ccs_socket_recvmsg_permission() to return -ENOMEM |
| 1961 |
|
rather than -EAGAIN. |
| 1962 |
|
|
| 1963 |
|
Fix 2009/05/19 |
| 1964 |
|
|
| 1965 |
|
@ Don't call get_fs_type() with a mutex held. |
| 1966 |
|
|
| 1967 |
|
Until now, when ccs_update_mount_acl() is called with unsupported |
| 1968 |
|
filesystem, /sbin/modprobe is executed from get_fs_type() to load |
| 1969 |
|
filesystem module. And get_fs_type() does not return until /sbin/modprobe |
| 1970 |
|
finishes. |
| 1971 |
|
|
| 1972 |
|
This means that it will cause deadlock if /sbin/modprobe (which is |
| 1973 |
|
executed via get_fs_type() in ccs_update_mount_acl()) calls |
| 1974 |
|
ccs_update_mount_acl(); although it won't happen unless an administrator |
| 1975 |
|
inserts execute_handler to call mount() requests in learning mode or to |
| 1976 |
|
add "allow_mount" entries to /proc/ccs/system_policy . |
| 1977 |
|
|
| 1978 |
|
I modified to unlock the mutex before calling get_fs_type(). |
| 1979 |
|
|
| 1980 |
|
Fix 2009/05/20 |
| 1981 |
|
|
| 1982 |
|
@ Add missing skb_free_datagram() call. (only 2.6.15 and earlier) |
| 1983 |
|
|
| 1984 |
|
Kernels before 2.6.16 do not have skb_kill_datagram(). |
| 1985 |
|
I copied skb_kill_datagram() from kernel 2.6.16, but it turned out that |
| 1986 |
|
I forgot to call skb_free_datagram() from skb_kill_datagram(). |
| 1987 |
|
|
| 1988 |
|
Version 1.6.8 2009/05/?? Feature enhancement release. |
TOMOYO
Parent Directory
Revision Log
Patch